Skip to content

HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backup to External Storage #6633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backup to External Storage #6633

merged 2 commits into from
Feb 18, 2025

Conversation

@vinayakphegde
Copy link
Contributor

No description provided.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@anmolnar
Copy link
Contributor

@vinayakphegde Please make this patch ready for review, if you're done with it.
You also need to rebase to the feature branch.

anmolnar
anmolnar reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, though I'm not sure if would split this patch into two by separating the framework related changes.

I would add a few trace level log lines for debugging backup events. Usually I just leave my custom logging in the code that I used for developing the patch. They would be useful for future debugging.

@vinayakphegde vinayakphegde marked this pull request as ready for review February 11, 2025 07:31
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@anmolnar
Copy link
Contributor

ping @wchevreuil Please help us reviewing this patch.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ HBASE-28957 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 11s HBASE-28957 passed
+1 💚 compile 3m 33s HBASE-28957 passed
+1 💚 checkstyle 0m 45s HBASE-28957 passed
+1 💚 spotbugs 1m 59s HBASE-28957 passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 59s the patch passed
+1 💚 compile 3m 30s the patch passed
-0 ⚠️ javac 0m 28s /results-compile-javac-hbase-backup.txt hbase-backup generated 4 new + 102 unchanged - 0 fixed = 106 total (was 102)
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 9s /results-checkstyle-hbase-backup.txt hbase-backup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 spotbugs 2m 12s the patch passed
+1 💚 hadoopcheck 11m 26s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
40m 23s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6633/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6633
JIRA Issue HBASE-28996
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux b00a1a1a83eb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-28957 / e18360d
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6633/5/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ HBASE-28957 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 59s HBASE-28957 passed
+1 💚 compile 1m 14s HBASE-28957 passed
+1 💚 javadoc 0m 40s HBASE-28957 passed
+1 💚 shadedjars 5m 53s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 2s the patch passed
+1 💚 compile 1m 15s the patch passed
+1 💚 javac 1m 15s the patch passed
+1 💚 javadoc 0m 40s the patch passed
+1 💚 shadedjars 5m 52s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 294m 31s hbase-server in the patch passed.
+1 💚 unit 21m 47s hbase-backup in the patch passed.
344m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6633/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6633
JIRA Issue HBASE-28996
Optional Tests javac javadoc unit compile shadedjars
uname Linux 08f8e899b1a7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-28957 / e18360d
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6633/5/testReport/
Max. process+thread count 4502 (vs. ulimit of 30000)
modules C: hbase-server hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6633/5/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

anmolnar
anmolnar approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@anmolnar
Copy link
Contributor

Could we have more eyeballs on this patch?
@ss77892 @wchevreuil @abhradeepkundu

abhradeepkundu
abhradeepkundu approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@abhradeepkundu abhradeepkundu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinayakphegde vinayakphegde changed the title HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backup to External Storage (Option 3) HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backup to External Storage Feb 18, 2025
@anmolnar anmolnar merged commit 2104620 into apache:HBASE-28957 Feb 18, 2025
1 check passed
anmolnar pushed a commit that referenced this pull request Mar 25, 2025
@vinayakphegde @anmolnar
HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backu…
77eeb71 
…p to External Storage (#6633)

* HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backup to External Storage

* fix spotless error
anmolnar pushed a commit that referenced this pull request Jul 28, 2025
@vinayakphegde @anmolnar
HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backu…
5e6ba37 
…p to External Storage (#6633)

* HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backup to External Storage

* fix spotless error
vinayakphegde added a commit to vinayakphegde/hbase that referenced this pull request Jul 29, 2025
@vinayakphegde
HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backu…
185bb68 
…p to External Storage (apache#6633)

* HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backup to External Storage

* fix spotless error
vinayakphegde added a commit to vinayakphegde/hbase that referenced this pull request Jul 29, 2025
@vinayakphegde
HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backu…
006529a 
…p to External Storage (apache#6633)

* HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backup to External Storage

* fix spotless error
anmolnar pushed a commit that referenced this pull request Sep 11, 2025
@vinayakphegde @anmolnar
HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backu…
35e01f2 
…p to External Storage (#6633)

* HBASE-28996: Implement Custom ReplicationEndpoint to Enable WAL Backup to External Storage

* fix spotless error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmolnar anmolnar anmolnar approved these changes

+1 more reviewer

@abhradeepkundu abhradeepkundu abhradeepkundu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vinayakphegde @Apache-HBase @anmolnar @abhradeepkundu